Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bin/docker-start helper script #956

Merged
merged 9 commits into from
Mar 25, 2025

Conversation

nkajic
Copy link
Contributor

@nkajic nkajic commented Jul 5, 2023

Hi @markshust
this is just an idea. Please see if it works for you and your project.

bin/docker-start can be used as standalone command to start docker (currently mac only) or can be used inside other automatisation scripts. I use it in another script which recreate local projects from project source and database dumps.

Greetings,
Neven

@what-the-diff
Copy link

what-the-diff bot commented Jul 5, 2023

PR Summary

  • New Command Added in README.md
    The README.md file, which serves as an instruction manual, has been updated. A new command named bin/docker-start has been introduced, making this command available to users.

  • Help Description Included in Makefile
    In the Makefile, which is used for establishing how to build the software, a help description for the new docker-start command has been incorporated. This addition will provide users with adequate information about what the command does.

  • Brand New Script to Check Docker Status
    A new script named compose/bin/docker-start has been created. This script will be used to verify whether Docker is running, using OrbStack or Docker Desktop. If Docker isn't running, the script will initiate the application.

@rangerz
Copy link
Contributor

rangerz commented Jul 6, 2023

@markshust is using OrbStack now. Docker Desktop is uninstalled.

@markshust
Copy link
Owner

This is interesting, I like it. Though I use OrbStack, we can check to see if that is installed first and if not, then fallback to Docker Desktop. I think this script needs some additions possibly for Linux as well to check if the docker daemon is started and if not, start it there as well.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Mar 25, 2025
@markshust markshust changed the base branch from master to release/next March 25, 2025 18:44
@markshust
Copy link
Owner

Thanks for this! I updated it to also detect OrbStack as well. Neat :)

@markshust markshust merged commit 919ae17 into markshust:release/next Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants